Release v2.3.14 #158
Merged
Release v2.3.14 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alangecker
commented
Oct 5, 2021
alangecker
commented
- Applied changes v2.3.5-v2.3.14 @alangecker
- updated wget to not use proxies #143 @mghadam
- fixed sed delimiter for CERTPATH and KEYPATH #144 @mghadam
- https_proxy: fix setting of ALLOWED_DOMAINS #145 @clandmeter
- coturn: expose ENABLE_HTTPS_PROXY env variable #146 #156 @clandmeter @omidmaldar
need to use another delimiter rather than `/` since the $CERTPATH and $KEYPATH variables contain `/` in the full path and cause the following error ``` `sed: -e expression #1, char 50: unknown option to `s' ```
Unfortunately, docker-compose does not respect noProxy hosts defined in ~/.docker/config.json or /etc/systemd/system/docker.service.d/http-proxy.conf and always uses proxy for healthcheck which causes problems. Resolved this by updating wget to not use proxies when checking for bbb-web health.
The coturn entrypoint checks if ENABLE_HTTPS_PROXY is set but it was not added the the compose environment stanza so it was never set in the container.
The template is not correctly checking if DEV_MODE is set to true. This will always set ALLOWED_DOMAINS to an empty string and allowing to generate certificates for any domain that points to the application.
Fixed some typos
updated wget to not use proxies
fixed sed delimiter for CERTPATH and KEYPATH
https_proxy: fix setting of ALLOWED_DOMAINS
coturn: expose ENABLE_HTTPS_PROXY env variable
fixed broken link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.