fix(component): SHIPPING-1526 adds description to Select & MultiSelect #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,6 +20,7 @@ import { SelectAction, SelectOption, SelectOptionGroup, SelectProps } from './ty | |||
| export const Select = typedMemo( | |||
| <T extends any>({ | |||
| action, | |||
| description, | |||
There was a problem hiding this comment.
You shouldn't need to destructure this, since it gets passed into the Input via rest.
| @@ -6,6 +6,7 @@ import { ListItemProps } from '../List/Item'; | |||
|
|
|||
| interface BaseSelect extends Omit<React.HTMLAttributes<HTMLInputElement>, 'children'> { | |||
| action?: SelectAction; | |||
| description?: string; | |||
There was a problem hiding this comment.
This can actually accept a string | FormControlDescription. See our Input implements it.
|
Just remembered, we probably want this for |
|
Yeah, if we can get this for |
agchan12
changed the title
agchan12
force-pushed
the
SELECT-BRANCH
branch
3 times, most recently
from
b1ce68e
to
efa27cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add description prop to Select dropdown
Why?
We support the description prop, but typescript doesn't recognise it as a prop
Testing/Proof
Select
MultiSelect
ping @deini @animesh1987 @chanceaclark