Filter and Pagination #2
Conversation
Support for pagination of resources, filtering and minimal update support.
Added read_only fields to Products and Images. Examples of product and image updates in a script.
Fixed the pagination to short circuit if the number of items in he page are less than the max, instead of waiting for an HTTP 204. Added more examples and test code
|
This is cool, thanks for the pull request. I’m currently going through the code and will point out a few small areas which aren’t quite what we’d expect. |
| @@ -17,21 +17,144 @@ Usage: | |||
|
|
|||
| ``` | |||
| #!/usr/bin/python | |||
| import bigcommerce.api | |||
| from bigcommerce.api import bigCommerce | |||
There was a problem hiding this comment.
This is okay for your own applications, but as a public facing API client for Bigcommerce, we’d want to keep the naming consistent with our brand, which is now Bigcommerce across all media, not BigCommerce or bigCommerce (bigcommerce in all lowercase is acceptable in some contexts).
|
OK, see if you like. |
accessed is not in the internal field dict.
|
Hey, I didn’t realise this had been updated. Sorry for the confusion. |
|
👍 We’re going to merge this, and take a shot at improving it to support all the recent API changes and improvements, as well as fold in changes from #3. |
|
Excellent. We recently added create and update support. To be released soon. Sent from my iPhone On Dec 10, 2013, at 11:38 PM, Mark Rickerby notifications@github.com wrote:
|
Lots of imports fixed. Create and delete implemented.
I was working on this API for a friend, who later told me about this project after I was almost finished. After taking a look, I noticed that iterating over more than 250 resources and filtering were not supported. Please pull if you like where I am heading with this project. Support for updating and creating will be coming soon.
Thanks,