feat(payment): PAYPAL-3520 Max capture amount failure #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-nick
requested review from
serhii-tkachenko,
andriiVitvitskyi1990 and
bc-dronov
bc-dronov
approved these changes
Apr 26, 2024
bc-peng
reviewed
Apr 30, 2024
| methodId: method.id, | ||
| }; | ||
|
|
||
| if (method.id === 'braintreepaypal') { |
There was a problem hiding this comment.
I think we agreed to avoid adding further payment method specific logic to core.
Is it possbile to place this in its own repo?
There was a problem hiding this comment.
@bc-peng yes, it is possible. I have updated PR with an appropriate changes. Take a look pls
animesh1987
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Handling an specific error related to max capture failure
Why?
To show the error message with an appropriate information for users
Depends on: bigcommerce/checkout-sdk-js#2485
Testing / Proof
Manual testing
@bigcommerce/team-checkout