Skip to content

Commit e82ebf9

Browse files
author
Luis Sanchez
committed
feat(shipping): CHECKOUT-2964 Allow making phone number required
1 parent 215e544 commit e82ebf9

File tree

2 files changed

+0
-16
lines changed

2 files changed

+0
-16
lines changed

src/form/form-selector.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ export default class FormSelector {
1818
const selectedCountry = find(countries, { code: countryCode });
1919

2020
return this._config.storeConfig.formFields.shippingAddressFields
21-
.map((field) => field.name === 'phone' ? { ...field, required: false } : field)
2221
.map((field) => this._processField(field, countries, selectedCountry));
2322
}
2423

src/form/form-selector.spec.js

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,6 @@ describe('FormSelector', () => {
8282

8383
expect(postCode.required).toBe(false);
8484
});
85-
86-
it('makes phone number NOT required', () => {
87-
const forms = formSelector.getShippingAddressFields(countries, 'JP');
88-
const phone = find(forms, { name: 'phone' });
89-
90-
expect(find(getFormFields(), { name: 'phone' }).required).toBe(true);
91-
expect(phone.required).toBe(false);
92-
});
9385
});
9486

9587
describe('#getBillingAddressFields()', () => {
@@ -160,12 +152,5 @@ describe('FormSelector', () => {
160152

161153
expect(postCode.required).toBe(false);
162154
});
163-
164-
it('does not modify the required value for phone number', () => {
165-
const forms = formSelector.getBillingAddressFields(countries, 'JP');
166-
const phone = find(forms, { name: 'phone' });
167-
168-
expect(phone.required).toBe(true);
169-
});
170155
});
171156
});

0 commit comments

Comments
 (0)