Skip to content

Commit fd7682c

Browse files
committed
refactor(payment): CHECKOUT-3060 Update method names to be consistent
BREAKING CHANGE: `getInitializePaymentMethod` and `isInitializingPaymentMethod` have now been renamed to `getInitializePayment` and `isInitializingPayment` respectively.
1 parent d031d27 commit fd7682c

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

src/checkout/checkout-store-error-selector.spec.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -175,18 +175,18 @@ describe('CheckoutStoreErrorSelector', () => {
175175
});
176176
});
177177

178-
describe('#getInitializePaymentMethodError()', () => {
178+
describe('#getInitializePaymentError()', () => {
179179
it('returns error if unable to initialize payment', () => {
180180
jest.spyOn(selectors.paymentStrategies, 'getInitializeError').mockReturnValue(errorResponse);
181181

182-
expect(errors.getInitializePaymentMethodError('braintree')).toEqual(errorResponse);
182+
expect(errors.getInitializePaymentError('braintree')).toEqual(errorResponse);
183183
expect(selectors.paymentStrategies.getInitializeError).toHaveBeenCalledWith('braintree');
184184
});
185185

186186
it('returns undefined if able to initialize payment', () => {
187187
jest.spyOn(selectors.paymentStrategies, 'getInitializeError').mockReturnValue();
188188

189-
expect(errors.getInitializePaymentMethodError('braintree')).toEqual(undefined);
189+
expect(errors.getInitializePaymentError('braintree')).toEqual(undefined);
190190
expect(selectors.paymentStrategies.getInitializeError).toHaveBeenCalledWith('braintree');
191191
});
192192
});
@@ -303,7 +303,7 @@ describe('CheckoutStoreErrorSelector', () => {
303303
});
304304
});
305305

306-
describe('#getInitializePaymentMethodError()', () => {
306+
describe('#getInitializePaymentError()', () => {
307307
it('returns error if unable to initialize shipping', () => {
308308
jest.spyOn(selectors.shippingStrategies, 'getInitializeError').mockReturnValue(errorResponse);
309309

src/checkout/checkout-store-error-selector.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export default class CheckoutStoreErrorSelector {
6363
this.getLoadShippingCountriesError() ||
6464
this.getLoadPaymentMethodsError() ||
6565
this.getLoadPaymentMethodError() ||
66-
this.getInitializePaymentMethodError() ||
66+
this.getInitializePaymentError() ||
6767
this.getLoadShippingOptionsError() ||
6868
this.getSelectShippingOptionError() ||
6969
this.getSignInError() ||
@@ -122,7 +122,7 @@ export default class CheckoutStoreErrorSelector {
122122
return this._paymentMethods.getLoadMethodError(methodId);
123123
}
124124

125-
getInitializePaymentMethodError(methodId?: string): Error | undefined {
125+
getInitializePaymentError(methodId?: string): Error | undefined {
126126
return this._paymentStrategies.getInitializeError(methodId);
127127
}
128128

src/checkout/checkout-store-status-selector.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,20 +171,20 @@ describe('CheckoutStoreStatusSelector', () => {
171171
});
172172
});
173173

174-
describe('#isInitializingPaymentMethod()', () => {
174+
describe('#isInitializingPayment()', () => {
175175
beforeEach(() => {
176176
jest.spyOn(selectors.paymentStrategies, 'isInitializing').mockReturnValue(false);
177177
});
178178

179179
it('returns true if initializing payment', () => {
180180
jest.spyOn(selectors.paymentStrategies, 'isInitializing').mockReturnValue(true);
181181

182-
expect(statuses.isInitializingPaymentMethod('foobar')).toEqual(true);
182+
expect(statuses.isInitializingPayment('foobar')).toEqual(true);
183183
expect(selectors.paymentStrategies.isInitializing).toHaveBeenCalledWith('foobar');
184184
});
185185

186186
it('returns false if not initializing payment', () => {
187-
expect(statuses.isInitializingPaymentMethod('foobar')).toEqual(false);
187+
expect(statuses.isInitializingPayment('foobar')).toEqual(false);
188188
expect(selectors.paymentStrategies.isInitializing).toHaveBeenCalledWith('foobar');
189189
});
190190
});

src/checkout/checkout-store-status-selector.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export default class CheckoutStoreStatusSelector {
6363
this.isLoadingShippingCountries() ||
6464
this.isLoadingPaymentMethods() ||
6565
this.isLoadingPaymentMethod() ||
66-
this.isInitializingPaymentMethod() ||
66+
this.isInitializingPayment() ||
6767
this.isLoadingShippingOptions() ||
6868
this.isSelectingShippingOption() ||
6969
this.isSigningIn() ||
@@ -122,7 +122,7 @@ export default class CheckoutStoreStatusSelector {
122122
return this._paymentMethods.isLoadingMethod(methodId);
123123
}
124124

125-
isInitializingPaymentMethod(methodId?: string): boolean {
125+
isInitializingPayment(methodId?: string): boolean {
126126
return this._paymentStrategies.isInitializing(methodId);
127127
}
128128

0 commit comments

Comments
 (0)