Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore four products per row on category pages when sidebar is empty. #1018

Merged
merged 1 commit into from
Jun 16, 2017
Merged

Conversation

sacr3dc0w
Copy link
Contributor

What?

Three products are displayed per row on category pages if one or more of these three conditions are met.

A) Faceted search is enabled.
B) Category contains subcategories.
C) Shop by price is enabled

If none are met, the main content area remains at 75% width, leaving a quarter of the content area empty. This is due to the styling of .page-sidebar + .page-content.

Using the {{or}} operator, verify if either of the three conditions are met. If neither are true, page content will stretch 100% and display four products by default.

Tickets / Documentation

Add links to any relevant tickets and documentation.

@sacr3dc0w sacr3dc0w changed the title Remove empty sidebar from category pages Restore four products per row on category page when sidebar is empty. Jun 13, 2017
@sacr3dc0w sacr3dc0w changed the title Restore four products per row on category page when sidebar is empty. Restore four products per row on category pages when sidebar is empty. Jun 13, 2017
Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an entry in the draft section of the change log file.

@junedkazi
Copy link
Contributor

Code LGTM 👍

@junedkazi
Copy link
Contributor

@sacr3dc0w can you please squash your commits I will merge this one.

#1000

Three products are displayed per row on category pages if one or more of these three conditions are met.

A) faceted search is enabled.
B) Category contains subcategories.
C) shop by price is enabled

If none are met, the main content area remains at 75% width, leaving a quarter of the content area empty. This is due to the styling of .page-sidebar + .page-content.

Using the {{or}} operator, verify if either of the three conditions are met. If neither are true, page content will stretch 100% and display four products by default.

changelog
@junedkazi junedkazi merged commit b22fb4a into bigcommerce:master Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants