Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MERC-4196: Fixes issue with Slick slider for mobile safari #1371

Merged
merged 1 commit into from
Oct 15, 2018
Merged

MERC-4196: Fixes issue with Slick slider for mobile safari #1371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ assets/js/bundle.js
assets/dist
*.js.map
*.zip
.idea/
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Draft
- Product review modal error message is now accurate. [#1370](https://github.com/bigcommerce/cornerstone/pull/1370)
- Fixes issue with Slick slider for mobile safari in iframe [#1371](https://github.com/bigcommerce/cornerstone/pull/1371)

## 2.5.1 (2018-10-10)
- Fix broken breadcrumb schema markup [#1362](https://github.com/bigcommerce/cornerstone/pull/1362)
Expand Down
2 changes: 2 additions & 0 deletions assets/scss/components/stencil/heroCarousel/_heroCarousel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
// -----------------------------------------------------------------------------

.heroCarousel {
width: 1px;
min-width: 100%;
margin-bottom: (spacing("double") + spacing("single"));
margin-top: -(spacing("single")); // 3

Expand Down
2 changes: 2 additions & 0 deletions assets/scss/components/stencil/productCarousel/_productCarousel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
// -----------------------------------------------------------------------------

.productCarousel { // 1
width: 1px;
min-width: 100%;
@include grid-row(
$behavior: nest
);
Expand Down
27 changes: 2 additions & 25 deletions templates/components/products/carousel.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,31 +3,8 @@
"dots": true,
"infinite": false,
"mobileFirst": true,
"slidesToShow": 2,
"slidesToScroll": 2,
"responsive": [
{
"breakpoint": 1260,
"settings": {
"slidesToScroll": 3,
"slidesToShow": {{ columns }}
}
},
{
"breakpoint": 800,
"settings": {
"slidesToScroll": 3,
"slidesToShow": 5
}
},
{
"breakpoint": 550,
"settings": {
"slidesToScroll": 3,
"slidesToShow": 3
}
}
]
"slidesToShow": {{ columns }},
christensenep marked this conversation as resolved.
Show resolved Hide resolved
"slidesToScroll": 3
}'
>
{{#each products}}
Expand Down