feat(bctheme): BCTHEME-51 Optional Custom Options (Modifiers) #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
junedkazi
suggested changes
Jul 1, 2020
| @@ -0,0 +1,3 @@ | |||
| <small> | |||
| {{#if required}}{{lang 'common.required'}}{{else}}{{lang 'common.optional'}}{{/if}} | |||
| </small> | |||
There was a problem hiding this comment.
Can we add an End of Line here.
There was a problem hiding this comment.
End of the line was added
| @@ -0,0 +1,3 @@ | |||
| <small> | |||
| {{#if required}}{{lang 'common.required'}}{{else}}{{lang 'common.optional'}}{{/if}} | |||
There was a problem hiding this comment.
@bc-as are we sure we want to surface Optional as a flag across all not not required fields.
There was a problem hiding this comment.
@junedkazi Yes, let's add it. We can re-evaluate this into a page builder toggle if necessary
There was a problem hiding this comment.
@bc-as can we create a ticket to explore the Optional being Optional via Page Builder.
junedkazi
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
For Custom Options (modifiers) that are not required for the shopper to fill out add the word "Optional" next to the field.
Tickets / Documentation
https://jira.bigcommerce.com/browse/BCTHEME-51
Screenshots (if appropriate)
ping @yurytut1993 @golcinho