feature(bctheme): BCTHEME-45 Update CornerStone to Utilize Existence of sale_price property for Determining Product/Variant Sale Status #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce property for Determining Product/Variant Sale Status
|
Autotagging @bigcommerce/storefront-team @davidchin |
golcinho
previously approved these changes
Jul 10, 2020
…ce property for Determining Product/Variant Sale Status (indents update)
|
@golcinho can you please approve current pr one more time - I just added new commit with new indents to make code more readable |
yurytut1993
changed the title
BC-tymurbiedukhin
approved these changes
Jul 10, 2020
golcinho
approved these changes
Jul 13, 2020
junedkazi
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
@BC-tymurbiedukhin @golcinho @bc-alexsaiannyi @junedkazi
Update CornerStone to Utilize Existence of sale_price property for Determining Product/Variant Sale Status.
I have changed the way how we check product status - on sale or not. And when sale properties (sale_price_with_tax & sale_price_without_tax) are not exist or their value equal to 0 - product status is NOT on sale. In other case we should add a sale badge
Tickets / Documentation
Ticket