Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storefront): BCTHEME-427 Insufficient button label on cart page #2013

Merged
merged 1 commit into from
Mar 18, 2021
Merged

fix(storefront): BCTHEME-427 Insufficient button label on cart page #2013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Fixed insufficient button label on cart page from action controls. [#2013](https://github.com/bigcommerce/cornerstone/pull/2013)
- "Skip to main content" now is visible when top banned is absent. [#2010](https://github.com/bigcommerce/cornerstone/pull/2010)
- Announce subscribing email field as mandatory. [#2011](https://github.com/bigcommerce/cornerstone/pull/2011)
- Changed insufficient link text for "Read More" links. [#2012](https://github.com/bigcommerce/cornerstone/pull/2012)
Expand Down
6 changes: 3 additions & 3 deletions lang/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
"freeshipping": "Free Shipping",
"reconfigure_product": "Configure '{name}'",
"shipping_peritem": "Per Item Shipping",
"remove_item": "Remove item from cart",
"remove_item": "Remove {name} from cart",
"confirm_delete": "Are you sure you want to delete this item?",
"coupons": {
"empty_error": "Please enter your coupon code.",
Expand Down Expand Up @@ -691,8 +691,8 @@
"products": {
"current_stock": "Current Stock:",
"quantity": "Quantity:",
"quantity_decrease": "Decrease Quantity:",
"quantity_increase": "Increase Quantity:",
"quantity_decrease": "Decrease Quantity of {name}",
"quantity_increase": "Increase Quantity of {name}",
"purchase_units": "{quantity, plural, =0{0 units} one {# unit} other {# units}}",
"max_purchase_quantity": "Maximum Purchase:",
"min_purchase_quantity": "Minimum Purchase:",
Expand Down
18 changes: 13 additions & 5 deletions templates/components/cart/content.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,12 @@ <h2 class="cart-item-name">
<label class="form-label cart-item-label" for="qty-{{id}}">{{lang 'products.quantity'}}</label>
<div class="form-increment">
{{#if can_modify}}
<button class="button button--icon" data-cart-update data-cart-itemid="{{id}}" data-action="dec">
<span class="is-srOnly">{{lang 'products.quantity_decrease'}}</span>
<button class="button button--icon"
data-cart-update
data-cart-itemid="{{id}}"
data-action="dec"
>
<span class="is-srOnly">{{lang 'products.quantity_decrease' name=name}}</span>
<i class="icon" aria-hidden="true"><svg><use xlink:href="#icon-keyboard-arrow-down" /></svg></i>
</button>
{{/if}}
Expand All @@ -110,8 +114,12 @@ <h2 class="cart-item-name">
data-action="manualQtyChange"
aria-live="polite"{{#unless can_modify}} disabled{{/unless}}>
{{#if can_modify}}
<button class="button button--icon" data-cart-update data-cart-itemid="{{id}}" data-action="inc">
<span class="is-srOnly">{{lang 'products.quantity_increase'}}</span>
<button class="button button--icon"
data-cart-update
data-cart-itemid="{{id}}"
data-action="inc"
>
<span class="is-srOnly">{{lang 'products.quantity_increase' name=name}}</span>
<i class="icon" aria-hidden="true"><svg><use xlink:href="#icon-keyboard-arrow-up" /></svg></i>
</button>
{{/if}}
Expand All @@ -133,7 +141,7 @@ <h2 class="cart-item-name">
<button class="cart-remove icon"
data-cart-itemid="{{id}}"
data-confirm-delete="{{lang 'cart.confirm_delete'}}"
aria-label="{{lang 'cart.remove_item'}}"
aria-label="{{lang 'cart.remove_item' name=name}}"
>
<svg><use xlink:href="#icon-close"></use></svg>
</button>
Expand Down