Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditional display of Apple Pay in Preview Cart #2036

Conversation

bobmurdoch
Copy link
Contributor

@bobmurdoch bobmurdoch commented Apr 12, 2021

What?

Inline block display for preview cart button styling overrode conditional display of Apple Pay button and resulted in an empty button when Apple Pay was not available. Applied conditional rules used from cart styling to preview cart.

Tickets / Documentation

N/A

Screenshots (if appropriate)

before2
after2
before-apple
after-apple

Inline block display for preview cart button styling overrode conditional display of Apple Pay button and resulted in an empty button when Apple Pay was not available.
@bigbot
Copy link

bigbot commented Apr 12, 2021

Autotagging @bigcommerce/themes-team

@BC-tymurbiedukhin
Copy link
Contributor

Could you please attach screenshot with case when applePay button is available and update changelog.md?

@bobmurdoch
Copy link
Contributor Author

Could you please attach screenshot with case when applePay button is available and update changelog.md?

Ok, done

Copy link
Contributor

@BC-tymurbiedukhin BC-tymurbiedukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BC-tymurbiedukhin
Copy link
Contributor

@minutiae thank you for contributing, your solution was extended at #2043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants