Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storefront): STRF-10056 Remove all amp related templates #2308

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

jordanarldt
Copy link
Contributor

@jordanarldt jordanarldt commented Jan 18, 2023

What?

Remove all templates related to Google AMP.

We have deprecated Google AMP, and browsing to an /amp/ resource will automatically be redirected to the non-amp resource. E.g. /amp/product -> /product

Requirements

  • CHANGELOG.md entry added (required for code changes only)

Tickets / Documentation

Add links to any relevant tickets and documentation.

Screenshots (if appropriate)

n/a

@bigcommerce/themes-team @bigcommerce/storefront-team

@jordanarldt jordanarldt marked this pull request as ready for review January 18, 2023 19:37
@bc-as
Copy link
Contributor

bc-as commented Jan 18, 2023

@jordanarldt can you remove this reference in config.json? Otherwise looks good to me.

https://github.com/bigcommerce/cornerstone/blob/master/config.json#L33

@bc-as bc-as merged commit 5f023e5 into bigcommerce:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants