Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(payment): PAYPAL-2079 removed accelerated checkout integration from theme #2341

Merged
merged 1 commit into from
Mar 30, 2023
Merged

refactor(payment): PAYPAL-2079 removed accelerated checkout integration from theme #2341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Draft
- Removed accelerated checkout integration [#2341](https://github.com/bigcommerce/cornerstone/pull/2341)

## 6.10.0 (03-23-2023)
- A bug with the display of the product quantity on the PDP [#2340](https://github.com/bigcommerce/cornerstone/pull/2340)
Expand Down
11 changes: 0 additions & 11 deletions assets/scss/components/stencil/cart/_cart.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,13 +535,6 @@ $card-preview-zoom-bottom-offset: 6rem;
}
}

.cart-acceleratedCheckoutButtons {
align-items: end;
display: flex;
flex-direction: column;
width: 100%;
}

.cart-additionalCheckoutButtons {
@extend %additionalCheckoutButtons;
}
Expand Down Expand Up @@ -681,10 +674,6 @@ $card-preview-zoom-bottom-offset: 6rem;
text-align: center;
}

.previewCart-acceleratedCheckoutButtons {
width: 100%;
}

.previewCart-additionalCheckoutButtons {
@extend %additionalCheckoutButtons;
padding-bottom: spacing("single");
Expand Down
4 changes: 0 additions & 4 deletions assets/scss/components/stencil/previewCart/_previewCart.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,6 @@
margin-top: spacing("single");
}

.previewCartCheckout-acceleratedCheckoutButtons {
width: 100%;
}

.previewCartCheckout-additionalCheckoutButtons {
p {
float: none !important; // 1
Expand Down
6 changes: 0 additions & 6 deletions config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,12 +322,6 @@
"pdp-non-sale-price-label": "",
"pdp-retail-price-label": "",
"pdp-custom-fields-tab-label": "",
"paymentbuttons-paypal-accelerated-checkout-color": "#444",
"paymentbuttons-paypal-accelerated-content-font-family": "Montserrat, Arial, Helvetica, sans-serif",
"paymentbuttons-paypal-accelerated-content-font-weight": "400",
"paymentbuttons-paypal-accelerated-content-color": "white",
"paymentbuttons-paypal-accelerated-content-label": "checkout",
"paymentbuttons-paypal-accelerated-border-color": "black",
"paymentbuttons-paypal-color": "gold",
"paymentbuttons-paypal-shape": "rect",
"paymentbuttons-paypal-label": "checkout",
Expand Down
59 changes: 0 additions & 59 deletions schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2882,65 +2882,6 @@
}
]
},
{
"type": "heading",
"content": "i18n.PaypalAcceleratedCheckoutButton",
"enable": "payPalAcceleratedCheckoutEnabled"
},
{
"type": "color",
"label": "i18n.ButtonColor",
"id": "paymentbuttons-paypal-accelerated-checkout-color",
"enable": "payPalAcceleratedCheckoutEnabled"
},
{
"type": "color",
"label": "i18n.ContentColor",
"id": "paymentbuttons-paypal-accelerated-content-color",
"enable": "payPalAcceleratedCheckoutEnabled"
},
{
"type": "select",
"label": "i18n.ButtonContent",
"id": "paymentbuttons-paypal-accelerated-content-label",
"enable": "payPalAcceleratedCheckoutEnabled",
"options": [
{
"value": "buy",
"label": "i18n.Buy"
},
{
"value": "checkout",
"label": "i18n.Checkout"
},
{
"value": "pay",
"label": "i18n.Pay"
},
{
"value": "buynow",
"label": "i18n.BuyNow"
},
{
"value": "paynow",
"label": "i18n.PayNow"
},
{
"value": "checkoutnow",
"label": "i18n.CheckoutNow"
},
{
"value": "proceedtocheckout",
"label": "i18n.ProceedToCheckout"
}
]
},
{
"type": "color",
"label": "i18n.BorderColor",
"id": "paymentbuttons-paypal-accelerated-border-color",
"enable": "payPalAcceleratedCheckoutEnabled"
},
{
"type": "heading",
"content": "i18n.SmartPaypalButton",
Expand Down
136 changes: 0 additions & 136 deletions schemaTranslations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4708,142 +4708,6 @@
"no": "Knappinnhold",
"ko": "버튼 내용"
},
"i18n.PaypalAcceleratedCheckoutButton": {
"default": "Paypal Accelerated Checkout button",
"fr": "Bouton du paiement accéléré PayPal",
"it": "Pulsante di checkout accelerato Paypal",
"zh": "Paypal“快捷结账”按钮",
"de": "Schaltfläche „Paypal Accelerated Checkout“",
"es": "Botón para habilitar el proceso de pago más rápido de PayPal",
"nl": "Knop versneld afrekenen van PayPal",
"pt": "Botão Paypal Accelerated Checkout",
"pt-BR": "Botão Paypal Accelerated Checkout",
"sv": "Knappen för PayPal accelererad utcheckning",
"es-MX": "Botón de pago acelerado con PayPal",
"es-419": "Botón de pago acelerado con PayPal",
"da": "Knappen PayPal-accelereret betaling",
"no": "Paypal Accelerated Checkout-knapp",
"ko": "PayPal 빠른 결제 버튼"
},
"i18n.ContentColor": {
"default": "Content color",
"fr": "Couleur du contenu",
"it": "Colore del contenuto",
"zh": "内容颜色",
"de": "Inhaltsfarbe",
"es": "Color del contenido",
"nl": "Kleur inhoud",
"pt": "Cor do conteúdo",
"pt-BR": "Cor do conteúdo",
"sv": "Innehållsfärg",
"es-MX": "Color del contenido",
"es-419": "Color del contenido",
"da": "Indholdsfarve",
"no": "Innholdsfarge",
"ko": "아이콘 텍스트 색상"
},
"i18n.Buy": {
"default": "Buy",
"fr": "Acheter",
"it": "Acquista",
"zh": "购买",
"de": "Kaufen",
"es": "Comprar",
"nl": "Kopen",
"pt": "Comprar",
"pt-BR": "Comprar",
"sv": "Köpa",
"es-MX": "Comprar",
"es-419": "Comprar",
"da": "Køb",
"no": "Kjøp",
"ko": "지금 구매"
},
"i18n.Checkout": {
"default": "Checkout",
"fr": "Paiement",
"it": "Checkout",
"zh": "结账台",
"de": "Bezahlvorgang",
"es": "Proceso de pago",
"nl": "Betaalomgeving",
"pt": "Finalização de compra",
"pt-BR": "Finalização de compra",
"sv": "Kolla upp",
"es-MX": "Pago",
"es-419": "Pago",
"da": "Kassen",
"no": "Betaling",
"ko": "체크아웃 페이지"
},
"i18n.Pay": {
"default": "Pay",
"fr": "Payer",
"it": "Paga",
"zh": "支付",
"de": "Bezahlen",
"es": "Pagar",
"nl": "Betalen",
"pt": "Pagar",
"pt-BR": "Pagar",
"sv": "Betala",
"es-MX": "Pagar",
"es-419": "Pagar",
"da": "Betal",
"no": "Betal",
"ko": "결제"
},
"i18n.PayNow": {
"default": "Pay Now",
"fr": "Payer maintenant",
"it": "Paga ora",
"zh": "立即付款",
"de": "Jetzt bezahlen",
"es": "Pagar ahora",
"nl": "Nu betalen",
"pt": "Pagar agora",
"pt-BR": "Pagar agora",
"sv": "Betala nu",
"es-MX": "Pagar ahora",
"es-419": "Pagar ahora",
"da": "Betal nu",
"no": "Betal nå",
"ko": "지금 구매"
},
"i18n.CheckoutNow": {
"default": "Checkout Now",
"fr": "Payer",
"it": "Procedi all'acquisto ora",
"zh": "立即结账",
"de": "Jetzt zur Kasse gehen",
"es": "Pagar ahora",
"nl": "Nu afrekenen",
"pt": "Finalizar a compra agora",
"pt-BR": "Finalizar a compra agora",
"sv": "Checka ut nu",
"es-MX": "Pagar ahora",
"es-419": "Pagar ahora",
"da": "Betal nu",
"no": "Betal nå",
"ko": "체크아웃 페이지"
},
"i18n.ProceedToCheckout": {
"default": "Proceed to checkout",
"fr": "Procéder au paiement",
"it": "Procedi al checkout",
"zh": "继续结账",
"de": "Weiter zur Kasse",
"es": "Ir al proceso de pago",
"nl": "Doorgaan naar betaalomgeving",
"pt": "Prosseguir para a finalização da compra",
"pt-BR": "Prosseguir para a finalização da compra",
"sv": "Fortsätt till utcheckningen",
"es-MX": "Continuar con el proceso de pago",
"es-419": "Continuar con el proceso de pago",
"da": "Gå til kassen",
"no": "Fortsett til kassen",
"ko": "결제 계속 진행"
},
"i18n.SmartPaypalButton": {
"default": "PayPal Button",
"fr": "Bouton PayPal",
Expand Down
4 changes: 0 additions & 4 deletions templates/components/cart/preview.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ <h1 class="modal-header-title">
<div class="previewCart">
<section class="previewCartCheckout">
{{#if cart.show_primary_checkout_button}}
{{#if cart.additional_checkout_buttons}}
<div data-cart-accelerated-checkout-buttons class="previewCartCheckout-acceleratedCheckoutButtons"></div>
{{/if}}

<a href="{{urls.checkout.single_address}}" class="button button--primary" data-primary-checkout-now-action>
{{lang 'cart.added_to_cart.proceed_to_checkout'}}
</a>
Expand Down
3 changes: 0 additions & 3 deletions templates/components/common/cart-preview.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ <h6 class="previewCartItem-name">
{{/each}}
</ul>
<div class="previewCartAction">
{{#if cart.additional_checkout_buttons}}
<div data-cart-accelerated-checkout-buttons class="previewCart-acceleratedCheckoutButtons"></div>
{{/if}}
{{#if cart.show_primary_checkout_button}}
<div class="previewCartAction-checkout">
<a
Expand Down
12 changes: 4 additions & 8 deletions templates/pages/cart.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,13 @@
{{{region name="cart_below_totals"}}}

{{#or customer (unless settings.hide_price_from_guests)}}
{{#if cart.additional_checkout_buttons}}
<div data-cart-accelerated-checkout-buttons class="cart-acceleratedCheckoutButtons cart-content-padding-right"></div>
{{/if}}

{{#if cart.show_primary_checkout_button}}
<div class="cart-actions cart-content-padding-right">
<a
class="button button--primary"
href="{{urls.checkout.single_address}}"
title="{{lang 'cart.checkout.title'}}"
data-primary-checkout-now-action
class="button button--primary"
href="{{urls.checkout.single_address}}"
title="{{lang 'cart.checkout.title'}}"
data-primary-checkout-now-action
>
{{lang 'cart.checkout.button'}}
</a>
Expand Down