Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storefront): BCTHEME-1626 "Please Select a file" popup forces shopper to re-upload file if the option type is "File Upload" and is set to required #2409

Merged
merged 2 commits into from
Dec 15, 2023
Merged

fix(storefront): BCTHEME-1626 "Please Select a file" popup forces shopper to re-upload file if the option type is "File Upload" and is set to required #2409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
830bade
fix(storefront): BCTHEME-1626 Please Select a file popup forces shopp…
Dec 13, 2023
2431b4c
Merge branch 'master' into BCTHEME-1626
bc-yevhenii-buliuk Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Replace Twitter logo with X logo within social sharing and social link components [#2387](https://github.com/bigcommerce/cornerstone/pull/2387)
- Added nvm config [#2389](https://github.com/bigcommerce/cornerstone/pull/2389)
- Displaying the Hidden cart_order_source Input Field on PDP page [#2392](https://github.com/bigcommerce/cornerstone/pull/2392)
- 'Please Select a file' popup forces shopper to re-upload file if the option type is 'File Upload' and is set to required [#2409](https://github.com/bigcommerce/cornerstone/pull/2409)
- Top Global Region Image Widget overlaps the mobile menu [#2402](https://github.com/bigcommerce/cornerstone/pull/2402)
- Changed default PayPal checkout button color [#2405](https://github.com/bigcommerce/cornerstone/pull/2405)
- Changed default PayPal checkout button size [#2406](https://github.com/bigcommerce/cornerstone/pull/2406)
Expand Down
6 changes: 3 additions & 3 deletions templates/components/cart/modals/configure-product.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div class="modal-header">
<h2
class="modal-header-title"
data-product-variant
<h2
class="modal-header-title"
data-product-variant
data-name="{{product_name}}"
>
{{lang 'cart.reconfigure_product' name=product_name}}
Expand Down
9 changes: 7 additions & 2 deletions templates/components/products/options/input-file.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@
{{> components/common/requireness-msg}}
</label>

<input class="form-file" type="file" id="attribute_file_{{id}}" name="attribute[{{this.id}}]" {{#if required}}required{{/if}}>
<input
class="form-file"
type="file"
id="attribute_file_{{id}}"
name="attribute[{{this.id}}]"
{{#and required (unless prefill)}}required{{/and}}
>
{{#if original_name}}
{{{lang 'products.file_option_set' url=file_url name=original_name}}}
<label>{{lang 'cart.remove_file'}}<input type="checkbox" name="{{file_remove}}"></label>
Expand All @@ -19,5 +25,4 @@
{{lang 'products.filetypes'}} <strong>{{file_types}}</strong>
{{/if}}
</p>

</div>
Loading