Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVDOCS-5972: [update] product videos #346

Merged
merged 4 commits into from
Jul 3, 2024
Merged

DEVDOCS-5972: [update] product videos #346

merged 4 commits into from
Jul 3, 2024

Conversation

bc-traciporter
Copy link
Collaborator

@bc-traciporter bc-traciporter commented Jun 21, 2024

DEVDOCS-5972

What changed?

Added product video section

Release notes draft

We're happy to announce the ability to query product videos using the storefront product graph.

Anything else?

ping {names}

@bc-traciporter bc-traciporter added the ready for review This PR is complete and awaiting a review. label Jun 21, 2024
Copy link
Contributor

@jamie-mckenzie jamie-mckenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thank you for replacing the URLs with BC specific marketing content. Love it!

docs/storefront/graphql/examples/products.mdx Outdated Show resolved Hide resolved
docs/storefront/graphql/examples/products.mdx Outdated Show resolved Hide resolved
docs/storefront/graphql/examples/products.mdx Outdated Show resolved Hide resolved
docs/storefront/graphql/examples/products.mdx Outdated Show resolved Hide resolved
@bc-traciporter
Copy link
Collaborator Author

Thank you @becomevocal that was really good feedback. I tested the graphQL query without ProductOptions and I agree it is not needed.
Screenshot 2024-07-02 at 12 43 26 PM

@becomevocal becomevocal merged commit 4380073 into main Jul 3, 2024
3 checks passed
@becomevocal becomevocal deleted the DEVDOCS-5972 branch July 3, 2024 01:59
@bc-traciporter
Copy link
Collaborator Author

Thank you @becomevocal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is complete and awaiting a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants