Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVDOCS-6014] Remove inconsistent enum for order payment_method #375

Conversation

Lucki2501
Copy link
Contributor

[DEVDOCS-] Remove inconsistent enum for order payment_method

What changed?

  • Removed inconsistent / misleading enum list from order payment_method parameter / attribute.

Release notes draft

  • Removed enum list from order payment_method parameter / attribute in POST and GET calls.

Anything else?

  • Order payment_method parameter / attribute was inconsistent because:
    • Enum list was included everywhere but PUT request
  • Order payment_method parameter / attribute was misleading because:
    • Enum list suggested you had limited allowed values, when the parameter is fully writable.

Copy link
Collaborator

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@bc-traciporter bc-traciporter merged commit 95de975 into bigcommerce:main Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants