Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVDOCS-6025: SF Form Fields, add requirements field for password field #476

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

bc-andreadao
Copy link
Collaborator

@bc-andreadao bc-andreadao commented Aug 26, 2024

DEVDOCS-6025

Relevant slack conversation https://bigcommerce.slack.com/archives/C9LNQDWKX/p1724860197700219

What changed?

  • add requirements field for password field types

Release notes draft

  • Updated the Form Fields endpoint of the REST Storefront API to include password requirements.

Anything else?

@bc-rowan
Copy link

Hey @bc-andreadao 👋

We're actually on a bit of a mission to kill off this custom form field type at the moment...

We've done some analysis and there are only 5 production stores total using this custom Password field today (plus a bunch of employee and partner sandboxes), and none of the use cases we've seen so far seem to be totally dependant on this field type over any other text entry field. I'll be reaching out to the current users with Support from tomorrow to try and learn more about how they're using it, and if we can successfully get them to move to another field type, we'll axe this one altogether.

@bc-andreadao
Copy link
Collaborator Author

Thanks @bc-rowan, let me know how it goes

@bc-andreadao bc-andreadao added the on hold Work is being place in a hold status. Will need follow up. label Aug 29, 2024
Copy link
Contributor

@bc-akshatkaushik bc-akshatkaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andrea 🙇‍♂️

@bc-andreadao bc-andreadao merged commit 166d215 into main Sep 13, 2024
3 checks passed
@bc-andreadao bc-andreadao deleted the DEVDOCS-6025-form-fields branch September 13, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Work is being place in a hold status. Will need follow up.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants