Rescue signal exception #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splittingred
requested changes
Nov 7, 2017
| @@ -61,7 +61,9 @@ def server | |||
| def start! | |||
| logger.info { 'Booting gRPC Server...' } | |||
| server.run_till_terminated | |||
| rescue Interrupt, SignalException, SystemExit | |||
There was a problem hiding this comment.
Can you wrap this method in # rubocop:disable Lint/ShadowedException and # rubocop:enable Lint/ShadowedException flags? (May need to rebase this from master)
splittingred
approved these changes
Nov 7, 2017
|
Thanks for this! I'll cut a 2.0.2 release now. |
!
|
@splittingred Thank you for taking care of this so fast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Fixes #32
How was it tested?
Spec + extensive testing in production