I need a common interface for the loaders. Formally, after this change we can call them Loaders. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Implement a NEW common interface (Loader). 2. All methods are instance ones, not static anymore. 3. Are implemented as singletons. 4. This change IS NOT BACKWARDS COMPATIBLE.
elmer-garduno
added a commit
that referenced
this pull request
Dec 20, 2011
Common interface for Loaders
|
Thanks, nice idea :-) |
|
I have staged a release with this changes in version 1.0.0, please let me know if it works. |
|
NIce! Thanks a lot. I will change my Maven dependencies accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JacksonJSONLoaderTest and SnakeYAMLLoader have suffered (or enjoyed) the following changes: