Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] add GKT #22

Merged
merged 4 commits into from
May 18, 2022
Merged

[FEATURE] add GKT #22

merged 4 commits into from
May 18, 2022

Conversation

fannazya
Copy link
Contributor

@fannazya fannazya commented Mar 2, 2022

Thanks for sending a pull request!
Please make sure you click the link above to view the contribution guidelines,
then fill out the blanks below.

Description

add GKT

What does this implement/fix? Explain your changes.

add GKT

Pull request type

  • [DATASET] Add a new dataset
  • [BUGFIX] Bugfix
  • [FEATURE] New feature (non-breaking change which adds functionality)
  • [BREAKING] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [STYLE] Code style update (formatting, renaming)
  • [REFACTOR] Refactoring (no functional changes, no api changes)
  • [BUILD] Build related changes
  • [DOC] Documentation content changes
  • [Sync] Synchronization with a repository
  • [OTHER] Other (please describe):

Changes

add GKT

Does this close any currently open issues?

#22
#23

Any relevant logs, error output, etc?

no

Checklist

Before you submit a pull request, please make sure you have to following:

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [FEATURE], [BREAKING], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage and all tests passing
  • Code is well-documented (extended the README / documentation, if necessary)
  • If this PR is your first one, add your name and github account to AUTHORS.md

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #22 (92cf77f) into main (b651a35) will decrease coverage by 1.01%.
The diff coverage is 95.57%.

@@             Coverage Diff             @@
##              main      #22      +/-   ##
===========================================
- Coverage   100.00%   98.98%   -1.02%     
===========================================
  Files           23       28       +5     
  Lines          989     1283     +294     
===========================================
+ Hits           989     1270     +281     
- Misses           0       13      +13     
Impacted Files Coverage Δ
EduKTM/GKT/GKTNet.py 91.59% <91.59%> (ø)
EduKTM/utils/torch/rnn.py 96.05% <96.05%> (ø)
EduKTM/GKT/GKT.py 100.00% <100.00%> (ø)
EduKTM/GKT/__init__.py 100.00% <100.00%> (ø)
EduKTM/GKT/etl.py 100.00% <100.00%> (ø)
EduKTM/__init__.py 100.00% <100.00%> (ø)
EduKTM/utils/torch/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b651a35...92cf77f. Read the comment docs.

Copy link
Contributor

@tswsxk tswsxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there, I notice there is a model parameters file named mgkt which is not expected. Please remove it.

@shshen-closer
Copy link
Collaborator

shshen-closer commented Apr 25, 2022 via email

@tswsxk
Copy link
Contributor

tswsxk commented May 18, 2022

Hi, there, I think a documentation that introduces this model is missing in docs

@shshen-closer
Copy link
Collaborator

shshen-closer commented May 18, 2022 via email

@tswsxk tswsxk merged commit d024d59 into bigdata-ustc:main May 18, 2022
@tswsxk tswsxk mentioned this pull request May 18, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants