Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadReferenceFile missing from Java API #1421

Closed
fnothaft opened this issue Mar 4, 2017 · 1 comment
Closed

loadReferenceFile missing from Java API #1421

fnothaft opened this issue Mar 4, 2017 · 1 comment

Comments

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Mar 4, 2017

Additionally, we should add loadTwoBit and loadContigMap functions to the Scala API. loadReferenceFile just loads these manually.

@fnothaft fnothaft added this to the 0.23.0 milestone Mar 4, 2017
@heuermh heuermh added this to Triage in Release 0.23.0 Mar 8, 2017
@heuermh
Copy link
Member

@heuermh heuermh commented Apr 14, 2017

+1 to adding new loadTwoBit and loadContigMap functions.

I'm not sure JavaADAMContext.loadReferenceFile is necessary, as there aren't any options or default values in its method signature.

fnothaft added a commit to fnothaft/adam that referenced this issue May 17, 2017
Resolves bigdatagenomics#1421. Also fixes `JavaADAMContextSuite` to actually use
`JavaADAMContext` instead of `ADAMContext`.
heuermh added a commit that referenced this issue May 18, 2017
Resolves #1421. Also fixes `JavaADAMContextSuite` to actually use
`JavaADAMContext` instead of `ADAMContext`.
@heuermh heuermh moved this from Triage to Completed in Release 0.23.0 May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.