Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loadReferenceFile missing from Java API #1421

Closed
fnothaft opened this issue Mar 4, 2017 · 1 comment · Fixed by #1536
Closed

loadReferenceFile missing from Java API #1421

fnothaft opened this issue Mar 4, 2017 · 1 comment · Fixed by #1536
Labels
enhancement pick me up!
Milestone
0.23.0

Comments

@fnothaft
Copy link
Member

fnothaft commented Mar 4, 2017 •
edited
Loading

Additionally, we should add loadTwoBit and loadContigMap functions to the Scala API. loadReferenceFile just loads these manually.
@fnothaft fnothaft added this to the 0.23.0 milestone Mar 4, 2017
@heuermh
Copy link
Member

heuermh commented Apr 14, 2017

+1 to adding new loadTwoBit and loadContigMap functions.

I'm not sure JavaADAMContext.loadReferenceFile is necessary, as there aren't any options or default values in its method signature.

fnothaft added a commit to fnothaft/adam that referenced this issue May 17, 2017
@fnothaft
[ADAM-1421] Add java API for loadReferenceFile.
64cafd3 
Resolves bigdatagenomics#1421. Also fixes `JavaADAMContextSuite` to actually use
`JavaADAMContext` instead of `ADAMContext`.
@fnothaft fnothaft mentioned this issue May 17, 2017
Merged
heuermh pushed a commit that referenced this issue May 18, 2017
@fnothaft @heuermh
[ADAM-1421] Add java API for loadReferenceFile.
fe1cba2 
Resolves #1421. Also fixes `JavaADAMContextSuite` to actually use
`JavaADAMContext` instead of `ADAMContext`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement pick me up!
Projects
None yet
Milestone
0.23.0
Development

Successfully merging a pull request may close this issue.

[ADAM-1421] Add java API for loadReferenceFile. fnothaft/adam
2 participants
@heuermh @fnothaft