New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1053] Clean up Transform #1081

Merged
merged 1 commit into from Jul 19, 2016

Conversation

Projects
None yet
3 participants
@fnothaft
Member

fnothaft commented Jul 18, 2016

Resolves #1053. Split out into many commits for reviewer convenience, but also to make it easier to address merge conflicts when #1011 merges. Will squash before merge.

Show outdated Hide outdated adam-cli/src/main/scala/org/bdgenomics/adam/cli/Transform.scala
}
}
def apply(rdd: RDD[AlignmentRecord],

This comment has been minimized.

@heuermh

heuermh Jul 18, 2016

Member

this cleans up nice!

@heuermh

heuermh Jul 18, 2016

Member

this cleans up nice!

This comment has been minimized.

@fnothaft

fnothaft Jul 18, 2016

Member

Agreed. I was quite pleased at the end. I was inspired by @ryan-williams's maybeX pattern, which we've got elsewhere.

@fnothaft

fnothaft Jul 18, 2016

Member

Agreed. I was quite pleased at the end. I was inspired by @ryan-williams's maybeX pattern, which we've got elsewhere.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jul 18, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1341/
Test PASSed.

AmplabJenkins commented Jul 18, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1341/
Test PASSed.

@heuermh heuermh modified the milestone: 0.20.0 Jul 18, 2016

@heuermh heuermh changed the title from Clean up Transform to [ADAM-1053] Clean up Transform Jul 18, 2016

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jul 19, 2016

Member

Will let you rebase and resolve conflicts, then I'll give a review pass.

Member

heuermh commented Jul 19, 2016

Will let you rebase and resolve conflicts, then I'll give a review pass.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jul 19, 2016

Member

Rebased!

Member

fnothaft commented Jul 19, 2016

Rebased!

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jul 19, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1355/
Test PASSed.

AmplabJenkins commented Jul 19, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1355/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jul 19, 2016

Member

LGTM

Squash then I'll merge.

Member

heuermh commented Jul 19, 2016

LGTM

Squash then I'll merge.

[ADAM-1053] Clean up if-clauses in Transform CLI.
Moves all if clauses into `maybeX` methods. Resolves #1053.
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jul 19, 2016

Member

Squashed!

Member

fnothaft commented Jul 19, 2016

Squashed!

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Jul 19, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1356/
Test PASSed.

AmplabJenkins commented Jul 19, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1356/
Test PASSed.

@heuermh heuermh merged commit c251f79 into bigdatagenomics:master Jul 19, 2016

1 check passed

default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jul 19, 2016

Member

Merged commit c251f79.

Thank you, @fnothaft!

Member

heuermh commented Jul 19, 2016

Merged commit c251f79.

Thank you, @fnothaft!

@fnothaft fnothaft deleted the fnothaft:issues/1053-clean-up-transform branch Jul 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment