[ADAM-1053] Clean up Transform #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| def apply(rdd: RDD[AlignmentRecord], |
There was a problem hiding this comment.
Agreed. I was quite pleased at the end. I was inspired by @ryan-williams's maybeX pattern, which we've got elsewhere.
|
Test PASSed. |
|
Will let you rebase and resolve conflicts, then I'll give a review pass. |
fnothaft
force-pushed
the
issues/1053-clean-up-transform
branch
from
a0a515f
to
ae9c422
Compare
|
Rebased! |
|
Test PASSed. |
|
LGTM Squash then I'll merge. |
Moves all if clauses into `maybeX` methods. Resolves bigdatagenomics#1053.
fnothaft
force-pushed
the
issues/1053-clean-up-transform
branch
from
ae9c422
to
c251f79
Compare
|
Squashed! |
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1053. Split out into many commits for reviewer convenience, but also to make it easier to address merge conflicts when #1011 merges. Will squash before merge.