New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-777] Add validation stringency flag for BQSR. #781

Merged
merged 1 commit into from Aug 20, 2015

Conversation

Projects
None yet
4 participants
@fnothaft
Member

fnothaft commented Aug 19, 2015

Resolves #777.

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Aug 19, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/846/
Test PASSed.

AmplabJenkins commented Aug 19, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/846/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 19, 2015

Member

The code looks reasonable to me. Could you add the the failing read (or a similar one) as a test case to demonstrate the fix?

Member

heuermh commented Aug 19, 2015

The code looks reasonable to me. Could you add the the failing read (or a similar one) as a test case to demonstrate the fix?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 20, 2015

Member

@beaunorgeot can you test with this patch to see if this passes on your end?

Member

fnothaft commented Aug 20, 2015

@beaunorgeot can you test with this patch to see if this passes on your end?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Aug 20, 2015

Member

@heuermh I am working on unit tests.

Member

fnothaft commented Aug 20, 2015

@heuermh I am working on unit tests.

@fnothaft fnothaft added this to the 0.17.1 milestone Aug 20, 2015

@AmplabJenkins

This comment has been minimized.

Show comment
Hide comment
@AmplabJenkins

AmplabJenkins Aug 20, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/850/
Test PASSed.

AmplabJenkins commented Aug 20, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/850/
Test PASSed.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Aug 20, 2015

Member

+1

Member

heuermh commented Aug 20, 2015

+1

@beaunorgeot

This comment has been minimized.

Show comment
Hide comment
@beaunorgeot

beaunorgeot Aug 20, 2015

Contributor

@fnothaft this patched worked successfully for me on the same file that generated issue 777. Well done!

Contributor

beaunorgeot commented Aug 20, 2015

@fnothaft this patched worked successfully for me on the same file that generated issue 777. Well done!

heuermh added a commit that referenced this pull request Aug 20, 2015

Merge pull request #781 from fnothaft/bqsr-md-error
[ADAM-777] Add validation stringency flag for BQSR.

@heuermh heuermh merged commit 60d66fd into bigdatagenomics:master Aug 20, 2015

1 check passed

default Merged build finished.
Details
@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh
Member

heuermh commented Aug 20, 2015

@fnothaft fnothaft referenced this pull request Nov 10, 2015

Closed

export valid fastq #856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment