Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-777] Add validation stringency flag for BQSR. #781

Merged
merged 1 commit into from
Aug 20, 2015

Conversation

fnothaft
Copy link
Member

Resolves #777.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/846/
Test PASSed.

@heuermh
Copy link
Member

heuermh commented Aug 19, 2015

The code looks reasonable to me. Could you add the the failing read (or a similar one) as a test case to demonstrate the fix?

@fnothaft
Copy link
Member Author

@beaunorgeot can you test with this patch to see if this passes on your end?

@fnothaft
Copy link
Member Author

@heuermh I am working on unit tests.

@fnothaft fnothaft added this to the 0.17.1 milestone Aug 20, 2015
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/850/
Test PASSed.

@heuermh
Copy link
Member

heuermh commented Aug 20, 2015

+1

@beaunorgeot
Copy link
Contributor

@fnothaft this patched worked successfully for me on the same file that generated issue 777. Well done!

heuermh added a commit that referenced this pull request Aug 20, 2015
[ADAM-777] Add validation stringency flag for BQSR.
@heuermh heuermh merged commit 60d66fd into bigdatagenomics:master Aug 20, 2015
@heuermh
Copy link
Member

heuermh commented Aug 20, 2015

Thanks @fnothaft, @beaunorgeot

@fnothaft fnothaft mentioned this pull request Nov 10, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants