Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FORMATS-106] Refactor Genotype and GenotypeAnnotation. #176

Closed
wants to merge 1 commit into from

Conversation

heuermh
Copy link
Member

@heuermh heuermh commented Jan 14, 2019

Fixes #106
Incorporates feedback from and replaces #108.
Note the diff is somewhat hard to read, for review please consider the whole file link.

@heuermh heuermh added this to the 0.12.0 milestone Jan 14, 2019
@heuermh heuermh requested a review from fnothaft January 14, 2019 23:23
@heuermh heuermh changed the title Refactor Genotype and GenotypeAnnotation. [FORMATS-106] Refactor Genotype and GenotypeAnnotation. Jan 14, 2019
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/bdg-formats-prb/188/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/bdg-formats-prb/189/
Test PASSed.

@heuermh
Copy link
Member Author

heuermh commented Jan 15, 2019

Note in #120 we use VariantAnnotation.readDepth for VCF INFO reserved key AD split to alternate read depth and VariantAnnotation.referenceReadDepth for VCF INFO reserved key AD split to reference read depth. VCF INFO reserved key DP "Combined depth across samples" is not mapped, because it doesn't make any sense after splitting.

This pull request uses GenotypeAnnotation.alternateReadDepth and AnnotationGenotype.referenceReadDepth for VCF FORMAT genotype reserved key AD, and Genotype.readDepth for VCF FORMAT genotype reserved key DP "Read depth". Should this be updated to do the same (i.e. drop DP mapping to readDepth and rename GenotypeAnnotation.alternateReadDepth to GenotypeAnnotation.readDepth)?

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/bdg-formats-prb/191/
Test PASSed.

@heuermh heuermh modified the milestones: 0.13.0, 0.14.0 Jul 2, 2019
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/bdg-formats-prb/192/
Test PASSed.

@heuermh heuermh modified the milestones: 0.14.0, 0.15.0 Aug 10, 2019
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/bdg-formats-prb/200/
Test PASSed.

@heuermh heuermh modified the milestones: 0.15.0, 0.16.0 Dec 3, 2019
@heuermh heuermh modified the milestones: 0.16.0, 0.17.0 Dec 9, 2020
@heuermh heuermh modified the milestone: 0.17.0 Aug 23, 2021
@heuermh
Copy link
Member Author

heuermh commented Aug 23, 2021

Closing as WontFix. Unfortunately there isn't a driver or reviewer for landing this large change.

@heuermh heuermh closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve gVCF support
2 participants