-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Hive-style partitioning #370
Conversation
Test FAILed. |
This worked fine with, ADAM with the PR bigdatagenomics/adam#1948 Note, you need to use partitioned parquet files generated from that version of the ADAM PR.
|
Jenkins, retest this please. |
Test PASSed. |
@jpdna can you add unit tests? |
Test PASSed. |
@@ -67,6 +68,20 @@ class VariantContextMaterializationSuite extends MangoFunSuite { | |||
|
|||
} | |||
|
|||
sparkTest("Can read Partitioned Parquet Genotypes") { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove empty line
} | ||
|
||
sparkTest("Read Partitioned Data") { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove empty line
This looks great @jpdna ! Just some minor spacing comments, otherwise it looks good to go on my side. |
Replaced with #379 |
Replaces #361
Works with ADAM PR bigdatagenomics/adam#1922
Reading partitioned files works, for example with command
Note, this PR currently fails tests, but so does Mango Master for me at, 328b519
I get test failure