Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FieldMessage component #57

Closed
wants to merge 3 commits into from
Closed

Add FieldMessage component #57

wants to merge 3 commits into from

Conversation

dancoates
Copy link
Contributor

No description provided.

@dancoates
Copy link
Contributor Author

One thing with this, because it is a component that has some depth, is that I'm not passing props down to the message elements. This could be a bit limiting in the future if someone wants to, for example, put some aria attributes on the message spans to tie them to the relevant inputs. I'm not quite sure what the best way to handle that is. I don't think we can just spam the spans with arbitrary props that the user passes in.

@dxinteractive
Copy link
Contributor

Yeah definitely not, React whinges if you try to set invalid tags on HTML elements.

I wouldn't mind having a standardised prop called htmlProps that accepts an object, specifically for putting arbitrary html attributes on the outermost html element of a component.

@dancoates
Copy link
Contributor Author

Yeah I like that idea

@allanhortle allanhortle deleted the feature/fieldmessage branch November 28, 2018 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants