Type safe fetched results controller #55

rcedwards · 2015-11-24T20:30:17Z

Added a type safe Fetched Results Controller thanks to @jgallagher and @zwaldowski
Updated the sample project with an example
Wrote unit test cases around the FRC
Updated the docs with better Markdown sugar

This helps illustrate the view controllers being swapped out when the stack is finished being constructed.

John G. had discovered the documented compiler issue observed when switching on the enum Compiler emits "PHI node operands are not the same type as the result!"

Previously all 100 books were being inserted here. That has been moved to the setup func so instead we'll just insert a single new book.

…errors are thrown on functions

zwaldowski · 2015-11-30T17:17:22Z

Example/BooksTableViewController.swift

+            sectionNameKeyPath: "firstInitial")
+        let frcDelegate = BooksFetchedResultsControllerDelegate(tableView: self.tableView)
+        frc.setDelegate(frcDelegate)
+        return frc


The FRC delegate should be weak, so shouldn't the frcDelegate be owned strongly somewhere?

got it. Updated.

This initializer takes a custom sort predicate however it was not being used at this time. This use of sort (and related ones) is problematic, as it might cause I/O to fetch all the objects in a section — Core Data arrays are lazy.

…r a given change An insert should have a newIndexPath, a delete should have an older indexPath etc. This way NSIndexPath? instances aren't being forcibly unwrapped.

rcedwards · 2015-12-01T14:29:10Z

I believe I've addressed everything if someone else wants to give a quick run through.

Work around a bug in Xcode 7.0 and 7.1 when running on iOS 8 - updated objects sometimes result in both an Update *and* and Insert call to didChangeObject, which makes no sense. Thankfully the bad Inserts have a non-nil "old" indexPath (which also makes no sense) - we check for that here and ignore those erroneous messages. For more discussion, see https://forums.developer.apple.com/thread/12184

rcedwards · 2015-12-01T19:55:40Z

@zwaldowski gotcha. Updated

zwaldowski · 2015-12-01T21:20:55Z

👍 We're well on our way to a great next release!

…ntroller Type safe fetched results controller

rcedwards added 20 commits November 23, 2015 12:32

Add the initial type safe fetched results controller

5874302

Add an arbitrary delay to the UI setup in the example app

ee42392

This helps illustrate the view controllers being swapped out when the stack is finished being constructed.

Add sample fetched results controller to example project

bf73ec9

Remove NSManagedObject requirement from FetchedResultsObjectChange enum

41342b0

John G. had discovered the documented compiler issue observed when switching on the enum Compiler emits "PHI node operands are not the same type as the result!"

Move testing data from Authors to Books

8f4ebd4

Add a test for the initial fetch of the FRC

8b150b1

Add a test for object deletion in the FRC

06437a4

Add a test for object moves in an FRC

260229d

Add test for an Update to an object in a FRC

486c608

Modify insert test to match other new tests

8622fce

Previously all 100 books were being inserted here. That has been moved to the setup func so instead we'll just insert a single new book.

Add willChange and didChange count assertions to the tests

5249170

Add a section insert test

ebc1d62

Add a test for deleting a section

cff7949

Add an icon to the sample app

35d810b

Update markdown of docs to include highlighted types and define what …

6b66452

…errors are thrown on functions

Add documentation for the EntityMonitorDelegate

49997b6

Ensure didAccessValue is called always

cda79f5

Add documentation on the typealias within EntityMonitorDelegate

93bc5a2

Reorganize FetchedResultsController class and document public API

b323fac

Update the example usage of the FetchedResultsController

8e536bf

zwaldowski reviewed Nov 30, 2015
View reviewed changes

Fix typo in the docs

e18ec53

rcedwards added 6 commits November 30, 2015 15:17

Capture the delegate object strongly within the BooksTableViewController

56b1865

Update comment on issue in Swift compiler

18d2323

Remove un-used custom sorted initializer

5b83ae9

This initializer takes a custom sort predicate however it was not being used at this time. This use of sort (and related ones) is problematic, as it might cause I/O to fetch all the objects in a section — Core Data arrays are lazy.

Syntactical update to sections mapping

81f5a5c

Modify switch statement to ensure correct index paths are returned fo…

10b1cfe

…r a given change An insert should have a newIndexPath, a delete should have an older indexPath etc. This way NSIndexPath? instances aren't being forcibly unwrapped.

Add John and Zach as authors to the pod spec

abf9d63

zwaldowski added a commit that referenced this pull request Dec 1, 2015

Merge pull request #55 from bignerdranch/rcedwards/fetched_results_co…

80a867c

…ntroller Type safe fetched results controller

zwaldowski merged commit 80a867c into master Dec 1, 2015

zwaldowski deleted the rcedwards/fetched_results_controller branch December 1, 2015 21:20

This was referenced Dec 1, 2015

Better pattern for InternalFetchedResultsControllerDelegate #56

Closed

Don't map section façade types on every access #57

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Type safe fetched results controller #55

Type safe fetched results controller #55

rcedwards commented Nov 24, 2015

zwaldowski Nov 30, 2015

rcedwards Nov 30, 2015

rcedwards commented Dec 1, 2015

rcedwards commented Dec 1, 2015

zwaldowski commented Dec 1, 2015

Type safe fetched results controller #55

Type safe fetched results controller #55

Conversation

rcedwards commented Nov 24, 2015

zwaldowski Nov 30, 2015

Choose a reason for hiding this comment

rcedwards Nov 30, 2015

Choose a reason for hiding this comment

rcedwards commented Dec 1, 2015

rcedwards commented Dec 1, 2015

zwaldowski commented Dec 1, 2015