Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple make_sequence and move to RemoteSequenceManager #30

Merged
merged 32 commits into from
Jul 19, 2022
Merged

Decouple make_sequence and move to RemoteSequenceManager #30

merged 32 commits into from
Jul 19, 2022

Conversation

justheuristic
Copy link
Collaborator

@justheuristic justheuristic commented Jul 18, 2022 •
edited
Loading

This PR:

  • finish renaming RemoteSequenceInfo -> RemoteSequenceManager (why: if it was an *Info, user would expect it to be similar to a dataclass; whereas in actuality, the class is doing heavy network interactions on its own)
  • implement RemoteSequenceManager.make_sequence (from https://pastebin.com/uXgy2U8B )
  • make RemoteSequentialInferenceSession use RemoteSequenceManager.make_sequence
  • make tests pass again
  • make it possible to create inference session without RemoteTransformerBlock
  • make a standalone test for RemoteSequential
  • rollback convert-model

@justheuristic justheuristic changed the title fault tolerance in chain inference_session [WIP] fault tolerance in chain inference_session Jul 18, 2022
@justheuristic justheuristic marked this pull request as ready for review July 18, 2022 23:07
@justheuristic justheuristic changed the title [WIP] fault tolerance in chain inference_session fault tolerance in chain inference_session Jul 18, 2022
@justheuristic justheuristic changed the title fault tolerance in chain inference_session Decouple make_sequence and move to RemoteSequenceManager Jul 18, 2022
@justheuristic
Copy link
Collaborator Author

Note: planned to implement fault tolerance in the same PR, will probably move to the next one

@justheuristic justheuristic merged commit f0c7383 into main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justheuristic @TimDettmers