Skip to content
This repository has been archived by the owner on Jul 14, 2020. It is now read-only.

Setup Transparent Publishing for convergence #27

Merged
merged 3 commits into from Oct 21, 2019
Merged

Setup Transparent Publishing for convergence #27

merged 3 commits into from Oct 21, 2019

Conversation

minkimcello
Copy link
Contributor

@minkimcello minkimcello commented Oct 18, 2019

Same setup as effection with the exception of the custom argument of NPM_PUBLISH we have in effection because we just need to publish the root directory for @bigtest/convergence.

TODOs

  • Add NPM_AUTH_TOKEN to secrets
  • Add GITHUB_POST_COMMENT_TOKEN to secrets
  • What should we do about the CircleCI setup? Remove it?
  • Add @frontsidejack as the owner of the package

@minkimcello
Copy link
Contributor Author

minkimcello commented Oct 18, 2019

@cowboyd Should I remove deploy from the circleci file?

Edit: I removed build and deploy from circleci. The build job was running npm run build and npm run docs so I combined them for prepack in json script.

@minkimcello minkimcello changed the title Setup Transparent Publishing Setup Transparent Publishing for convergence Oct 21, 2019
Copy link
Contributor

@cowboyd cowboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange. It appears that the CircleCI build is not running on your fork....

@cowboyd cowboyd merged commit 1eba314 into bigtestjs:master Oct 21, 2019
@cowboyd cowboyd mentioned this pull request Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants