This repository has been archived by the owner on Jul 14, 2020. It is now read-only.
Split manifest server into separate builder and server #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnicklas
force-pushed
the
manifest-server-split
branch
from
5c34750
to
15f8660
Compare
jnicklas
added a commit
that referenced
this pull request
Feb 21, 2020
The fingerprinted filename is stored in the state. One minor change in this PR is that the orchestrator no longer creates the atom, but must be supplied with one. The reason for this is that we need to be able to extract data from the atom in our tests, and there is no other way of getting hold of it. Depends on #101
jnicklas
added a commit
that referenced
this pull request
Feb 21, 2020
The fingerprinted filename is stored in the state. One minor change in this PR is that the orchestrator no longer creates the atom, but must be supplied with one. The reason for this is that we need to be able to extract data from the atom in our tests, and there is no other way of getting hold of it. Depends on #101
Working towards #93 If we copy the manifest so we get uniquely identified manifests then we need to have control over the static file server which serves these files. This splits the current manifest server into two separate parts, a builder which uses parcel to generate the files, these are just stored to disk and not actually served, and a server which is just a static file server using express.
jnicklas
force-pushed
the
manifest-server-split
branch
from
15f8660
to
f07af3d
Compare
jnicklas
added a commit
that referenced
this pull request
Feb 21, 2020
The fingerprinted filename is stored in the state. One minor change in this PR is that the orchestrator no longer creates the atom, but must be supplied with one. The reason for this is that we need to be able to extract data from the atom in our tests, and there is no other way of getting hold of it. Depends on #101
jnicklas
added a commit
that referenced
this pull request
Feb 21, 2020
The fingerprinted filename is stored in the state. One minor change in this PR is that the orchestrator no longer creates the atom, but must be supplied with one. The reason for this is that we need to be able to extract data from the atom in our tests, and there is no other way of getting hold of it. Depends on #101
16 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards #93
If we copy the manifest so we get uniquely identified manifests then we need to have control over the static file server which serves these files. This splits the current manifest server into two separate parts, a builder which uses parcel to generate the files, these are just stored to disk and not actually served, and a server which is just a static file server using express.