Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move menu cosmetics #2834

Merged

Conversation

kisslorand
Copy link
Contributor

Requirements

BTT or MKS TFT

Description

This PR brings small cosmetics to the Move menu.

Y+ and Y- icons were confusing as the icon associated to Y+ clearly shows the bed moving to back and the icon associated to Y- clearly shows a bed mowing forward. As most of printers have the zero position when the bed is fully on the back, moving the bed to the back the Y coordinate decreases and moving the bed to forward the Y coordinate increases.
In this PR the icons representation now correspond to the actual movement of the bed.

The coordinate values on the top of the display got a small attention, they are moved to the same height as reminders and menu names are, when a reminder is displayed, it will remain visible until it naturally goes away, than the coordinate values are visible again.

Before:

Move_2

Move_3

After:

Move_0

Move_1

Move_6

@rondlh
Copy link

rondlh commented Sep 12, 2023

Does this mean that everyone will have to change the inverted_axis value for Y in config.ini?

I have changed my Move menu like shown below, I feel it is much more intuitive than the 2 options currently provided by the TFT.
Move_Layout3

@kisslorand
Copy link
Contributor Author

Does this mean that everyone will have to change the inverted_axis value for Y in config.ini?

No.

@bigtreetech bigtreetech merged commit f5a7ec0 into bigtreetech:master Sep 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants