Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce knomi_main_color configuration variable #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ybalrid
Copy link

@Ybalrid Ybalrid commented Sep 9, 2023

This replaces usage of hard coded RED color (0xFF0000) in a bunch of places, allowing the user to change that color by chaning the value inside color_settings.hpp

@Ybalrid
Copy link
Author

Ybalrid commented Sep 9, 2023

Also, I am thinking of optionally having a graphics color and a text color as two separate colors. My personal machine is entirely purple+green themed. Most Voron builds are two colors.

Replacing the GIF for the animation is simple enough, and documented, but I had to search around to find how and where the text and progress bar graphics were drawn. Hence the above small change!

This replaces usage of hard coded RED color (0xFF0000) in a bunch of places, allowing the user to change that color by chaning the value inside `color_settings.hpp`
@TheSin-
Copy link

TheSin- commented Nov 7, 2023

this is great I'd like to expand on this and make it configurable in the startup UI, this will pair amazingly well with my multitool selector.

@Ybalrid
Copy link
Author

Ybalrid commented Nov 9, 2023

this is great I'd like to expand on this and make it configurable in the startup UI; this will pair amazingly well with my multitool selector.

Yeah, that would be the first step of the refactoring needed if you want to make this setting dynamic. The global static variable would need to not be const.

As it is with KNOMU most of the on-screen animations are red because they are embedded .GIF files that have red pixels in them. So as-is most of it is red anyway 🤔

On the build I am running on my unit, I have recolored by hand all the animation frames in purple and green, as it is the color scheme of my machine, but there was still a few UI elements (like temperature gauges) that were red, and clashing.

@Ybalrid
Copy link
Author

Ybalrid commented Jan 18, 2024

I will revisit this once I get around to rebasing my code on the current firmware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants