feat!: Support semicolon-separated lists in Factor Value fields #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sellth
force-pushed
the
factor_value_lists
branch
from
5bdf735
to
92563a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #95 +/- ##
=======================================
Coverage 96.52% 96.53%
=======================================
Files 29 29
Lines 3428 3431 +3
=======================================
+ Hits 3309 3312 +3
Misses 119 119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sellth
changed the title
holtgrewe
approved these changes
Jan 19, 2024
sellth
changed the title
sellth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor Values behave very similar to Characteristics in Sample Name materials, but are meant to represent “variable manipulated by an experimentalist with the intention to affect biological systems” i.e. sample conditions.
https://isa-specs.readthedocs.io/en/latest/isatab.html?highlight=factor%20value#factor-value
Since we already process semicolon-separated list-type content in Characteristics, it makes a lot of sense to also do this for Factor Value nodes. fixes #93
To do:
BEGIN_COMMIT_OVERRIDE
feat!: Support semicolon-separated lists in Factor Value fields
END_COMMIT_OVERRIDE