Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New routine: snappy pull-processed-data #115

Merged
merged 12 commits into from
Aug 18, 2022

Conversation

eudesbarbosa
Copy link
Member

@eudesbarbosa eudesbarbosa commented Aug 2, 2022

closes #114

Changes

  • Implemented new routine: snappy pull-processed-data
  • Pinned setuptools version, v58 - later versions break support for use_2to3

@eudesbarbosa eudesbarbosa marked this pull request as ready for review August 10, 2022 11:49
@eudesbarbosa eudesbarbosa marked this pull request as draft August 11, 2022 12:03
@eudesbarbosa eudesbarbosa marked this pull request as ready for review August 15, 2022 14:02
Copy link
Member

@holtgrewe holtgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

What in our code base or of our dependencies needs 2to3?

@eudesbarbosa
Copy link
Member Author

It is not the first time this issue shows up, it is coming from prospector - test dependency. I could also just pin it there, instead of base...

Previous PR: #87
Issue in their repo: prospector-dev/prospector#438

@eudesbarbosa eudesbarbosa merged commit e2d9c14 into bihealth:master Aug 18, 2022
@eudesbarbosa eudesbarbosa deleted the 114-pull-processed-data branch August 18, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New routine to get processed data: snappy pull-processed-data
2 participants