Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python installation script in order to accept python3.11 #1377

Conversation

gromdimon
Copy link
Collaborator

Just small changes for #1376

@gromdimon
Copy link
Collaborator Author

By the way, I found more artifacts, but I'm not sure if they need to be updated:

  • ./.readthedocs.yaml#L11
  • ..versioneer.py - Just a general update of versioneer

@gromdimon gromdimon self-assigned this Mar 4, 2024
@gromdimon gromdimon added this to the v1.0.0 milestone Mar 4, 2024
@gromdimon gromdimon marked this pull request as ready for review March 4, 2024 12:42
@gromdimon gromdimon requested a review from mikkonie March 4, 2024 12:55
@mikkonie
Copy link
Collaborator

mikkonie commented Mar 4, 2024

By the way, I found more artifacts, but I'm not sure if they need to be updated:

* [ ]  `./.readthedocs.yaml#L11`

* [ ]  `..versioneer.py` - Just a general update of versioneer

Versioneer will be updated as a part of #1374, I'm doing that right now. Readthedocs build is not that critical, but I can also upgrade it as part of that issue.

Copy link
Collaborator

@mikkonie mikkonie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will merge :)

@mikkonie mikkonie merged commit 009782a into dev Mar 4, 2024
6 checks passed
@mikkonie mikkonie deleted the 1376-update-python-installation-utility-script-to-support-python311 branch March 4, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants