Pass the parameter connection when register doctrine post persister listener #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morinceline
changed the title
Nek-
suggested changes
Jul 20, 2018
| @@ -78,7 +78,7 @@ private function registerDoctrinePostPersistListener(array $config, ContainerBui | |||
| DoctrinePostPersistListener::class | |||
| ) | |||
| ->setArgument(0, new Reference('biig_domain.dispatcher')) | |||
| ->addTag('doctrine.event_subscriber', array('connection' => 'default')) | |||
| ->addTag('doctrine.event_subscriber', array('connection' => $connection)) | |||
There was a problem hiding this comment.
Can you add the related test please?
Nek-
reviewed
Jul 20, 2018
| ], | ||
| ]]; | ||
|
|
||
| $container = new ContainerBuilder(); | ||
| $extension->load($config, $container); | ||
|
|
||
| $this->assertTrue($container->hasDefinition('biig_domain.post_persist_listener.doctrine_default')); | ||
| $this->assertTrue($container->hasDefinition('biig_domain.post_persist_listener.doctrine_custom_doctrine')); |
There was a problem hiding this comment.
It does not test the tags (which is what you fixed)
morinceline
force-pushed
the
fix/register-doctrine-connection
branch
from
ef600d0
to
535e889
Compare
Nek-
reviewed
Jul 20, 2018
| "connection" => "custom_doctrine" | ||
| ] | ||
| ] | ||
|
|
There was a problem hiding this comment.
please remove this space :) . And all is ok! (you can execute php-cs-fixer here https://github.com/biig-io/DomainComponent/blob/master/.php_cs.dist )
morinceline
force-pushed
the
fix/register-doctrine-connection
branch
from
535e889
to
e41d37e
Compare
Nek-
approved these changes
Jul 20, 2018
|
Thank you @morinceline ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #35