Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exiftool dependency for geo-module #725

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

mtiessen1175
Copy link
Collaborator

@mtiessen1175 mtiessen1175 commented Dec 18, 2023

Since the native PHP-exiftool functions do not support all file-formats (see here), the use of exiftool would be helpful for extracting more specific metadata, like GeoTIFF-tags. Exiftool might also be helpful for metadata-extraction from videos #462.

Tasks:

  • Adding the exiftool dependency to the app & worker docker-containers.

composer.json Outdated Show resolved Hide resolved
@mzur
Copy link
Member

mzur commented Dec 18, 2023

This is related to biigle/geo#44.

mzur
mzur previously approved these changes Dec 19, 2023
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍 This will be merged together with the biigle/geo pull request that actually implements the GeoTIFF feature. Please be sure to link this PR there, too.

Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need proj4php here? Can't you add it to the composer.json of biigle/geo?

@mtiessen1175
Copy link
Collaborator Author

Why do you need proj4php here? Can't you add it to the composer.json of biigle/geo?

Yes, you're right it will only be used in the geo-module. I did not think about this properly when I installed it into core previously.

.docker/worker.dockerfile Outdated Show resolved Hide resolved
mzur
mzur previously approved these changes Jul 18, 2024
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the storage disk configuration again, as the module is not installed by default. You can open a PR with the disk configuration to the dev-modules branch once this is merged.

@mtiessen1175
Copy link
Collaborator Author

Please remove the storage disk configuration again, as the module is not installed by default. You can open a PR with the disk configuration to the dev-modules branch once this is merged.

That makes sense! I removed it.

@mtiessen1175 mtiessen1175 requested a review from mzur August 20, 2024 09:07
mzur
mzur previously approved these changes Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants