-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exiftool dependency for geo-module #725
base: master
Are you sure you want to change the base?
Conversation
This is related to biigle/geo#44. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now 👍 This will be merged together with the biigle/geo pull request that actually implements the GeoTIFF feature. Please be sure to link this PR there, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need proj4php
here? Can't you add it to the composer.json of biigle/geo?
Yes, you're right it will only be used in the geo-module. I did not think about this properly when I installed it into core previously. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the storage disk configuration again, as the module is not installed by default. You can open a PR with the disk configuration to the dev-modules
branch once this is merged.
… in dev-modules branch) This reverts commit 7c2fc62.
That makes sense! I removed it. |
Since the native PHP-exiftool functions do not support all file-formats (see here), the use of exiftool would be helpful for extracting more specific metadata, like GeoTIFF-tags. Exiftool might also be helpful for metadata-extraction from videos #462.
Tasks: