-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort by similarity #173
Sort by similarity #173
Conversation
UI is unfinished and sorting sequence does not seem to equal the sequence returned by the API.
The similarity sort UI/UX is still unfinished.
Here is a demo of the current UX: Screencast.from.26.06.2024.15.51.09.webmThat's happening:
@dlangenk Any comments? |
The code was correct but ESLint is an older version that does not support the syntax yet.
Why do we need that additional click? In Maia if I remember correctly I could just hover over the thumbnail and click on the pin icon to pin a new annotation. Otherwise it looks great 👍 |
I decided against the pin button because in Largo there already is the "show annotation" button and I thought two buttons too much. Also, all sorting options should work more or less in the same way, so I wanted this as a button in the sorting tab. An additional sorting option should not get in the way of the typical Largo use case. |
I rather meant to have the second button only visible when you activate the similarity sort. This way it would be easy to use and in line with MAIA usage. |
I though it easier for the users to just click on the whole thumbnail when they should select a reference. So you think the additional button next to the "show annotation" button would be better UX? Maybe if the "pin" button is shown permanently (not only on hover) whenever the "select reference" state is active then the required action is more clear for the users? |
Showing it permanently would be an option but the on hover would be better I think because then it wouldn't cover the image and it would be exactly like MAIA. When activating the similarity sort you could show the select a reference annotation as you already did in the video (or add "by clicking on the pin icon when hovering over a thumbnail"). Instead of next to the show annotation button you could put it on the left. But that is just my personal "make it balanced" Monk. |
I like it. Here are the same steps of the video again with the updated UI: Screencast.from.27.06.2024.11.55.41.webmWhen the similarity sorting is active, you can now directly select a new reference with the buttons. Also the button is permanently shown for the selected reference and you can reset the sorting with a click on this button, too. I chose the bottom right button position because the dismissed state is already shown at the top left of the selected reference (you can see this in the video). |
Looks really good this way👍 |
Resolves #125
Todo: