Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skip and retry option for failed file uploads #30

Merged
merged 102 commits into from
Jun 14, 2024
Merged

Add skip and retry option for failed file uploads #30

merged 102 commits into from
Jun 14, 2024

Conversation

lehecht
Copy link
Contributor

@lehecht lehecht commented May 13, 2024 •
edited
Loading

  • Add button and functionality to retry upload
  • Add button and functionality to skip failed files
  • Prevent outdated delete requests to be executed
  • Handle duplicated files in different storage requests
  • Handle exceeded storage quota
  • Add/Change tests for controller
  • Add/Change tests for delete job
  • Create PR to update fileBrowser (Update file browser core#835)
  • Fix editable fileBrowser after successfull upload
  • Fix 404 not found error for failed deletions
  • Run and commit npm run prod

Closes #11.

@lehecht
Add retry option after failed file upload
fbdd3c5
@lehecht
Fix uncaught error in promise
b3e2e25 
Remove error throwing, because it is handled later.
@lehecht
Show progress while retrying upload
f749019
@lehecht
Reset uploaded file sizes after finish
0fa8c83
@lehecht
Fix incorrect upload progress for failed files
66ee178
@lehecht
Add file warning info to directory
26001b9
@lehecht
Change failed file info
53eb9a5
@lehecht
Save failed file names only
79af7a5
@lehecht
Center text
2f5fe2d
@lehecht
Make code more understandable
f8f21c6
@lehecht
Fix uncaught err in promise
83fa0de 
Add promise parts together
@lehecht
Fix problems with failed chunked files
e8e12c9 
Don't submit storage request as long as there are failed files.
@lehecht
Submit request when failed files are skipped
22447a5
@lehecht
Fix wrong view for complete uploads
218f601 
Variable finished was false even when upload was complete.
Set finish on true after the upload is complete and
set editable on false after file browser view was changed.
@lehecht
Change skip button to only redirect page
2d3297c 
Remove finishing storage request.
@lehecht
Add retry_count attribute
805550d
@lehecht
Fix problem with incomplete chunked files
b53f9e2 
When delete request ist outdated (retry counts don't match), don't delete chunked files
@lehecht
Cast boolean strings to bool
43824b8
@lehecht
Add retryChunk parameter to upload method
cdd0505 
If retryChunk is true, the retry counter will be increased on backend side.
@lehecht
Remove deletion of storage request file
db85aee 
File is removed at the end of the job.
@lehecht
Remove unused lines
cefde0f 
Check for uploaded chunks is done in the controller.
@lehecht
Fix bug not recognizing duplicated files
ebd1d7c 
File paths were compared instead to look for identical file names.
@lehecht
Rename errors to enable distinction
7d6f582
@lehecht
Handle duplicated files
7010bb4 
Show message when duplicates files are detected.
@lehecht
Add check for exceeded storage quota
64ee390 
Previous check only contained size of selected files,
but did not consider already used storage.
@lehecht
Remove unused import
52955f3
@lehecht
Update StorageRequestFileControllerTest
df266d0
@lehecht
Update DeleteStorageRequestFileTest
a0c2b50
@lehecht
Add tests to DeleteStorageRequestFileTest
8f9bf91
@lehecht
Add tests to StorageRequestFileControllerTest
863076c
@lehecht
Copy link
Contributor Author

lehecht commented Jun 3, 2024 •
edited
Loading

@mzur
How should a storage request be handled if all files have been uploaded successfully, but the request couldn't be updated in the end?

Currently, only the handleErrorResponse method is used. Should I add there also a retry button?

@mzur
Copy link
Member

mzur commented Jun 3, 2024

No, just keep it like that. The user should be able to click submit again (right?). Also, they could reload the page and find the storage request still pending. Then they can click submit again, too.

@lehecht lehecht requested a review from mzur June 4, 2024 06:00
mzur
mzur reviewed Jun 6, 2024
View reviewed changes
src/Http/Controllers/Api/StorageRequestFileController.php Outdated Show resolved Hide resolved
src/Http/Controllers/Api/StorageRequestFileController.php Outdated Show resolved Hide resolved
src/resources/assets/js/createContainer.vue Outdated Show resolved Hide resolved
src/resources/views/create.blade.php Outdated Show resolved Hide resolved
src/resources/assets/js/createContainer.vue Outdated Show resolved Hide resolved
src/resources/assets/js/createContainer.vue Show resolved Hide resolved
src/resources/assets/js/createContainer.vue Outdated Show resolved Hide resolved
mzur
mzur requested changes Jun 6, 2024
View reviewed changes
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some previous comments are not resolved yet. Also, I don't see the failed/duplicate file states in the UI any more (i.e. changed color and icon):

image

@lehecht
Copy link
Contributor Author

lehecht commented Jun 7, 2024 •
edited
Loading

@mzur

Some previous comments are not resolved yet. Also, I don't see the failed/duplicate file states in the UI any more (i.e. changed color and icon):

I don't know how to reproduce this bug. For me everything seems to work. Can you describe what you did?

@mzur
Copy link
Member

mzur commented Jun 10, 2024

I don't know how to reproduce this bug. For me everything seems to work. Can you describe what you did?

You are right. I pulled the recent changes and recompiled the assets. Now it works again. Maybe my biigle/core assets haven't been up to date...

@lehecht lehecht requested a review from mzur June 11, 2024 07:25
mzur
mzur reviewed Jun 12, 2024
View reviewed changes
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost finished! Only one comment now. And maybe it's a good idea to add a second test case for a chunked file upload that is retried now. Finally, could you clarify the discussion about this.finished above?

src/resources/views/create.blade.php Outdated Show resolved Hide resolved
@lehecht lehecht requested a review from mzur June 13, 2024 10:46
@mzur mzur merged commit e8302d1 into master Jun 14, 2024
2 checks passed
@mzur mzur deleted the skip-err-files branch June 14, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzur mzur Awaiting requested review from mzur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve upload error handling
2 participants
@lehecht @mzur