Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a PumpStream to assemble a chunked file #31

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Implement a PumpStream to assemble a chunked file #31

merged 3 commits into from
Jun 13, 2024

Conversation

mzur
Copy link
Member

@mzur mzur commented Jun 12, 2024

The new implementation only loads a single chunk into memory at a time.

Todo:

  • Fix actual implementation
  • Implement test for pump class

Resolves #26

@mzur mzur marked this pull request as ready for review June 13, 2024 14:25
@mzur mzur merged commit 57c7f64 into master Jun 13, 2024
2 checks passed
@mzur mzur deleted the issue-26 branch June 13, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try to improve AssembleChunkedFile
1 participant