Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when opening search results in new tab #54

Closed
THEtomaso opened this issue Feb 20, 2018 · 2 comments
Closed

Bug when opening search results in new tab #54

THEtomaso opened this issue Feb 20, 2018 · 2 comments
Labels
bug Something isn't working XUL XUL Extension related issues

Comments

@THEtomaso
Copy link

THEtomaso commented Feb 20, 2018

Description:
When opening image search results in new tabs, the extension doesn't work.

How to reproduce (tested with XUL version 1.0 under Pale Moon, x64):

  1. Search for some image.
  2. Right-click on one of the search results and choose "Open link in new tab".
    Result:
    The extension doesn't work, and there's no "View image" and "Search by image" option.
@bijij
Copy link
Owner

bijij commented Feb 20, 2018

This was related to an issue introduced in the standard 1.6.1 release. I'll update the XUL package with the fix in 1.6.2 later today at some point.

@THEtomaso
Copy link
Author

THEtomaso commented Feb 20, 2018

You should consider hosting it at PaleMoon.org:
https://addons.palemoon.org/extensions/

Instructions here:
http://developer.palemoon.org/Add-ons:Site/Submit

If you want to target it specifically for Pale Moon (not actually required), you'll find some info here:
https://forum.palemoon.org/viewtopic.php?f=19&t=16785/

..and in case you're wondering; no signing is required:
https://forum.palemoon.org/viewtopic.php?f=46&t=10570#p73714
:)

bijij added a commit that referenced this issue Feb 21, 2018
@bijij bijij added bug Something isn't working XUL XUL Extension related issues labels Feb 21, 2018
@bijij bijij closed this as completed Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working XUL XUL Extension related issues
Projects
None yet
Development

No branches or pull requests

2 participants