Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: signup_notes, rename rider_notes. #385

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

teesloane
Copy link
Contributor

@teesloane teesloane commented Jun 7, 2024

Describe your changes

Follow up to the closing of #340 , closes #385

This was done so that we could include signup related information when riders signup for a delivery.
It has also been on the backlog to rename "rider_notes" to "delivery_instructions"

Delivery Instructions - To be shown when a rider is doing a delivery. Sometimes contains personal information (ex: "Francis is hearing impaired and might not hear when you ring the doorbell."

Signup Notes - Instructions specific to choosing what to sign up for - for example: "{recipient A} is in the same building as {recipient B} - if you can signup for both that would be awesome!

Screenshot

CleanShot.2024-06-07.at.12.52.48.mp4

Product Update

"Hi Dispatchers! It is now possible to include "rider signup notes—these will show on the page where a rider assigns themselves a specific delivery. This might be useful for letting riders know about co-located deliveries, for example. Please avoid adding personal identifying information into the rider signup notes."

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added tests.
  • Are there other PRs or Issues that I should link to here?
  • Will this be part of a product update? If yes, please write one phrase
    about this update in the description above.

This was done so that we could include signup related information when
riders signup for a delivery.

It has also been on the backlog to rename "rider_notes" to "delivery_instructions"
Copy link
Member

@mveytsman mveytsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@teesloane teesloane merged commit 8e2de46 into main Jun 19, 2024
1 check passed
@teesloane teesloane deleted the ty/340-pickup-notes-2 branch June 19, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants