Schema wants OTP to be a string, but it's really a number

[Phault]

Providing the OTP by passing it through the CLI fails as the value provided is coerced into a number, rather than staying a string like the executor schema expects.

>  nx run utilities:deploy-npm --otp=634119
Property 'otp' does not match the schema. '634119' should be a 'string'.

As a workaround, I've patched the schema to expect a number and it works just fine.

Using Nx 14.3.6 and ngx-deploy-npm 4.1.2.

[dianjuar]

I'm not entirely familiar with the OTP parameter. Is the OTP parameter always a number?

---

As a workaround, I'll suggest doing the following:

- nx run utilities:deploy-npm --otp=634119
+ nx run utilities:deploy-npm --otp='634119'

[dianjuar]

If the right path is changing the OTP type to a number, not a string, we are open to receiving the contribution.

A good starting point is changing the type of the OTP parameter on:

• https://github.com/bikecoders/ngx-deploy-npm/blob/main/packages/ngx-deploy-npm/src/executors/deploy/schema.json#L32
• https://github.com/bikecoders/ngx-deploy-npm/blob/main/packages/ngx-deploy-npm/src/executors/deploy/schema.d.ts#L25

[Phault]

I'm not entirely familiar with the OTP parameter. Is the OTP parameter always a number?

Not entirely sure, but it seems like it is. Still, string seems more correct for a password and it's also what npm themselves list the parameter as, so I think the proper fix would be Nx making their type conversion for CLI parameters smarter. I've created nrwl/nx#11519 in hopes this will get fixed.

For now I think the proper workaround would be accepting both number and string. I will create a PR shortly.

As a workaround, I'll suggest doing the following:

- nx run utilities:deploy-npm --otp=634119
+ nx run utilities:deploy-npm --otp='634119'

This unfortunately makes no difference, it still gets converted to a number by Nx. :(

[dianjuar]

I was able to make it run with:

- nx run utilities:deploy-npm --otp=634119
+ npx nx deploy node-lib1 --otp "'634119'"

But I still think it can be improved by changing the type