-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for optional namespaces #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM, but version in change log is set to xx |
// }); | ||
fromAll().when({ #{callbacks.join(', ')} }); | ||
"'' | ||
<<~JS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of Javascript hardcoded in Ruby files. Have you considered using ERB templates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll create an issue about refactoring tasks.
Overview
Optional namespacing for aggregate/projection streams and events allowing for isolation between different applications.
As a result, aggregates event listeners will load events generated within the namespace. If no namespace is provided, identical event or aggregate names may result in undefined behavior.
Usage
Implementation
If a namespace name is provided:
namespace
attribute containing the namespace name.namespace
in their metadata.