Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Separate translator into i18n and lang modules #117

Merged
merged 1 commit into from
Jan 4, 2017
Merged

Separate translator into i18n and lang modules #117

merged 1 commit into from
Jan 4, 2017

Conversation

aminmarashi
Copy link

  • Change translator pattern in i18n scanner

  • Replace all instances of translator.translateText() with translate()

  • Separate and refactor lang module for ui

@coveralls
Copy link

Coverage Status

Coverage increased (+2.0006%) to 83.272% when pulling 5365da9 on aminmarashi:refactor-tests into 1436af1 on binary-com:dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.6%) to 83.863% when pulling 2145fcb on aminmarashi:refactor-tests into 1436af1 on binary-com:dev.

- Change translator pattern in i18n scanner

- Replace all instances of translator.translateText() with translate()

- Separate and refactor lang module for ui

- Move html translation to lang.js

- Add more tests for i18n
@aminmarashi aminmarashi merged commit 5f83d70 into binary-com:dev Jan 4, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+2.6%) to 83.863% when pulling 104e5cc on aminmarashi:refactor-tests into 1436af1 on binary-com:dev.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants