Qingwei/fix trade ui #114
Qingwei/fix trade ui #114
Conversation
src/_selectors/FullTradeSelectors.js
Outdated
There was a problem hiding this comment.
Why are we using string actually?
Because of input type=date ?
If it was Date it would just be a '>' comparison.
There was a problem hiding this comment.
Because that's what backend returns ~
And it represent time instead of Date, we need to use string like
'09:09:00' and '12:00:00' to determine if the market is close or open, any idea of improvement ?
There was a problem hiding this comment.
Definitely we will have a transform on the server_data inputs. We can even have it as an extension to live-api. Not today, but lets consider it soon.
There was a problem hiding this comment.
Good idea about extending live-api ~
Yea, right now let's have it as string :(
|
Done with review. Fix small issues and merge conflict and I merge ;) |
qingweibinary
force-pushed
the
qingwei/fix_trade_ui
branch
from
adaed04 to
70234df
Compare
qingweibinary
force-pushed
the
qingwei/fix_trade_ui
branch
from
d9e031d to
98a9c65
Compare
2 participants
This depends on
#109