This repository was archived by the owner on Sep 2, 2023. It is now read-only.
Nuru/Fix_Language_Change_Bug #145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| api.getAssetIndex(); | ||
| api.getTradingTimes(); | ||
| export const changeLanguage = async (dispatch, ln) => { | ||
| api.events.on('authorize', response => response.error ? |
There was a problem hiding this comment.
We want to use the promise + await approach in this case.
Though I am not sure even if this needs to be here?!?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Attached conatined few changes that should address the language change login/authorization issues . The second invalidcontract error might be as a result of an expired contract id and has not yet been addressed by this PR. Would look further for that Monday.