This repository was archived by the owner on Sep 2, 2023. It is now read-only.
Replaced chart with binary-charts #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| "binary-live-api": "*", | ||
| "classnames": "^2.2.3", | ||
| "echarts": "^3.0.2", | ||
| "echarts": "^3.1.1", |
There was a problem hiding this comment.
We probably don't need echarts as a dependency anymore?
There was a problem hiding this comment.
if we replace all existing chart then yes
In progress
qingweibinary
force-pushed
the
qingwei/replace_charts
branch
from
f653b43 to
8ce38fb
Compare
borisyankov
added a commit
that referenced
this pull request
Mar 1, 2016
Replaced chart with binary-charts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge as there's some UI bugs