This repository was archived by the owner on Sep 2, 2023. It is now read-only.
Replace tick stream with tick history #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qingweibinary Review please? |
src/_actions/WatchlistActions.js
Outdated
| if (isSubscribed) { | ||
| api.subscribeToTick(symbol); | ||
| try { | ||
| await api.getTickHistory(symbol, { end: 'latest', count: 10, subscribe: 1 }); |
There was a problem hiding this comment.
we probably need adjust_start_time: 1
| api.getTradingTimes(new Date()); | ||
| }; | ||
|
|
||
| export const getTickHistory = async (symbol) => { |
There was a problem hiding this comment.
this export looks really random, how about this?
we place this logic in action creator, then dispatch action from LiveData, which is the common pattern we have been using.
There was a problem hiding this comment.
@qingweibinary i don't think thats necessary. The method does change a state in any way beside making a call to an WS. HAd it been we are updating or changing a state example let's say logging history or something then would have made sense. I think it should be ok like this just like how we handle the one above it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace tick stream with tick history for watchlist.
https://trello.com/c/CQUfIUva/2-handle-the-exception-this-market-is-presently-closed